Skip to content

Remove test forward compat #14995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2022

Conversation

Kordyjan
Copy link
Contributor

Fixes #14989

…rward-compat tests (compiling selected projects with "-Yscala-release 3.0")"

This reverts commit e39b618.
@Kordyjan Kordyjan force-pushed the remove-test-forward-compat branch from d149276 to 75f56c1 Compare April 21, 2022 09:11
@Kordyjan Kordyjan force-pushed the remove-test-forward-compat branch from d65e32b to 3617147 Compare April 21, 2022 11:40
@smarter smarter added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Apr 21, 2022
@Kordyjan Kordyjan force-pushed the remove-test-forward-compat branch from ea940d2 to 13a4961 Compare April 21, 2022 12:39
@Kordyjan
Copy link
Contributor Author

@smarter Do we need to backport that into 3.1.3? I don't see any reason.

@smarter
Copy link
Member

smarter commented Apr 22, 2022

I was thinking that if we're planning to definitely remove scala-output-release, we should remove it from 3.1.3 so that people don't start relying on it.

@Kordyjan
Copy link
Contributor Author

This PR only removes forward compatibility tests from the community build. They are triggered only on nightly builds, so they don't matter outside of the main branch.

Actual removing the feature requires more caution and will come as a PR next week.

@smarter
Copy link
Member

smarter commented Apr 22, 2022

Ah I see, thanks!

@smarter smarter removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Apr 22, 2022
@Kordyjan Kordyjan merged commit fd6ac43 into scala:main Apr 22, 2022
@Kordyjan Kordyjan deleted the remove-test-forward-compat branch April 22, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2022-04-21 failed
5 participants